the vanity lights only work if three conditions are met
1)The lights(headlights or park) must be on
2) the visor is in a postion that the passenger can see in the mirror,ie the vanity light doesnt come on if the visor is still in the up position and it wont come on if the visor is hard against the windscreen
3) the little screen to the mirror must be open.
Try it!
Turn on park lights
swivel down visor so that you could see in the mirror
open the little screen.....voila
one other thing...make sure the visor is securely clipped into the retainer in the middle of the car,this is where the contact is....